DimensionDev / Maskbook-Talks

Where talks of Maskbook happen.
7 stars 1 forks source link

Transform language to 'en' instead of 'zh' using i18n-ally #56

Closed zhouhanseng closed 4 years ago

zhouhanseng commented 4 years ago

As I'm using en-US as my default language setting of firefox.

I want to configure i18n-ally as

{
 //...
 "i18n-ally.displayLanguage": "en",
}

Then I can get

image

rather than image

Tedko commented 4 years ago

As I'm using en-US as my default language setting of firefox.

I want to configure i18n-ally as


{

 //...

 "i18n-ally.displayLanguage": "en",

}

Then I can get

image

rather than

image

Thx hancheng. Can you do a PR? Happy to merge and thx for the contribution

zhouhanseng commented 4 years ago

Yeah! I need to have the write access.

septs commented 4 years ago

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork

@zhouhanseng

Tedko commented 4 years ago

Thx for the contribution

Jack-Works commented 4 years ago

This settings is only for the vscode extension. It doesn't affect what you see in the browsers.

papac25 commented 4 years ago

This settings is only for the vscode extension. It doesn't affect what you see in the browsers.

[]()