DimensionDev / Maskbook-Talks

Where talks of Maskbook happen.
7 stars 1 forks source link

If the deployment target was newer than the target that os_unfair_lock() became available deprecation warnings were generated for use of OSSpinLock. Now OSSpinLock isn't used if the deployment target is >= the OS version where os_unfair_lock() became available. #62

Closed papac25 closed 3 years ago

papac25 commented 3 years ago

If the deployment target was newer than the target that os_unfair_lock() became available deprecation warnings were generated for use of OSSpinLock. Now OSSpinLock isn't used if the deployment target is >= the OS version where os_unfair_lock() became available.

New Pull Request Checklist

This merge request fixes / refers to the following issues: #3136

Pull Request Description

Fix deprecation warnings for OSSpinLock

If the deployment target was newer than the target that os_unfair_lock() became available deprecation warnings were generated for use of OSSpinLock. Now OSSpinLock isn't used if the deployment target is >= the OS version where os_unfair_lock() became available.

If you want to test this manually you can temporarily set the iOS Deployment target in the SDWebImage project to 11 or newer (and the same for the other OS targets) and build for iOS. In master you will get the deprecation warnings and in this PR branch the warning will not be present.

Originally posted by @phoney in https://github.com/SDWebImage/SDWebImage/pull/3137

septs commented 3 years ago

@jk234ert iOS ?

Jack-Works commented 3 years ago

Hmm, I'm confused, what is this?