search

DimensionDev / Maskbook

The portal to the new, open Internet. ([I:b])
https://mask.io
GNU Affero General Public License v3.0
1.5k stars 311 forks source link

[Bounty] Integrate Bancor, a Decentralized exchange, in Mask Plugin #4016

Closed tzhan28 closed 2 years ago

tzhan28 commented 3 years ago

Catalogue

Part 1: Problem Description

Background Bancor is a dex on ETH that has been around since 2018 and has seen good volumes over the past year. We think Bancor will be a good fit for the mask trading plugin

Solution Create a plugin that integrate Bancor. The UI should be identical to other swaps

polygon swaps eth swaps

See the existing polygon swaps and ETH swaps.

Anylink cashtag with viable ticker, like $ETH on Twitter, could trigger the plugin. Swaps are also accessible via top line search bar and the swap entry on the left bar menu

Language like I just swapped $aa worth of xxx token for yyy token, can I make money? should be added to help spread the word.

Part 2: Resources

Part 3: Contact and Support

@yisiliu for ideas @Jack-Works for implementations Mask Network discord server: https://discord.gg/4Xccj7a75Q 1inch discord server: https://discord.com/invite/hxPhPDW

Submission Requirements Please include demo to show the integration is working.

Winner Announcement Date Winners will be announced at the conclusion of Open DeFi Hackathon

Judging Criteria Have a working demo. Clean code & tech design Clear UI, easy to use and generally good user experience

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 225.0 MASK (1467.0 USD @ $6.52/MASK) attached to it.

spiritbroski commented 3 years ago

hello @tzhan28 or @yisiliu could you please explain this part 

Language like
I just swapped $aa worth of xxx token for yyy token, can I make money?
should be added to help spread the word.

do you meant that everytime somebody type for example "$ETH" the plugin will be shown like snapshot plugin does? like this :

image

could you please elaborate? thanks

yisiliu commented 3 years ago

@spiritbro1 nuh the scenario is that you hover your mouse on any cashtag tickers like $ETH and it'll show a floating window. It's better if you can download our extension and try it yourself.

spiritbroski commented 3 years ago

@yisiliu oh so we just need to add bancor to here?

image

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 weeks, 5 days from now. Please review their action plans below:

1) iotaaxel has started work.

I have read the overview and would like to integrate Bancor as a mask plugin.

Learn more on the Gitcoin Issue Details page.

tzhan28 commented 2 years ago

@yisiliu oh so we just need to add bancor to here?

image

Yes. Any updates?

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 225.0 MASK (2310.75 USD @ $10.27/MASK) has been submitted by: