DimensionalDevelopment / JustEnoughIDs

Use the 1.13 chunk format in 1.12 to remove the block, item, and biome ID limits
MIT License
31 stars 33 forks source link

Incompatible with Resplendent Prism from Astral Sorcery #136

Open sam-kirby opened 4 years ago

sam-kirby commented 4 years ago

This mod applies overwrite mixins to EnchantmentHelper, thereby overwriting the patches applied by Astral Sorcery's PatchModifyEnchantmentLevels.

As a result, whilst the tooltips for enchanted items continue to display as though the resplendent prism is functioning, the enchantments are not applied when an item is used. This can be fixed by avoiding using overwrites in MixinEnchantmentHelper, or by reapplying Astral's patches using mixins in the presence of Astral only.

Further, Astral uses short Enchantment IDs in EnchantmentUpgradeHelper, leaving it incompatible with IDs over 255.