DimensionalDevelopment / JustEnoughIDs

Use the 1.13 chunk format in 1.12 to remove the block, item, and biome ID limits
MIT License
31 stars 33 forks source link

Multiple Issues when using JEID's in large modpack. (UndergroundBiomes & Issues with Hell Biome) #179

Open KirinFuji opened 3 years ago

KirinFuji commented 3 years ago

Hello, I have been building a large modpack and had to switch to using NotEnough IDs due to issues from JEIDs.

UndergroundBiomes: When any custom gravity block from UB (Eclogite Sand, Eclogite Gravel, Etc) falls the falling block renders as a random other block. For example, when the blocks would fall I would see upside down nether stairs until it hit the ground and materialized back to Eclogite Gravel.

Hell Biome replaced with Plains Biome: When I entered the nether to check on things, the Hell Biome was not there, instead saying it was a Plains biome. This caused none of the nether ores to generate and overworld mobs would spawn.

Both very strange issues, however they seemed like some kind of Biome ID and Block ID issue so I disabled JEID and enabled NEID and both issues were fixed. I am writing this to inform you that there are some issues with how things play along with JEID.

I deleted the world file before and after as I am just building and testing things right now.

Included Mods ``` advancedsolars-1.0.7.jar ae2stuff-0.7.0.4-mc1.12.2.jar AE2WTLib-1.12.2-1.0.34.jar AkashicTome-1.2-12.jar AppleCore-mc1.12.2-3.4.0.jar appliedenergistics2-rv6-stable-7.jar AutoRegLib-1.3-32.jar Baubles-1.12-1.5.2.jar bdlib-1.14.3.12-mc1.12.2.jar BetterAdvancements-1.12.2-0.1.0.77.jar BetterBuildersWands-1.12.2-0.13.2.271+5997513.jar BiblioCraft[v2.4.5][MC1.12.2].jar binnie-mods-1.12.2-2.5.1.203.jar BiomesOPlenty-1.12.2-7.0.1.2444-universal.jar BNBGamingCore-1.12.2-0.12.0.jar BNBGamingLib-1.12.2-2.17.6.jar Botania+r1.10-364.4.jar BrandonsCore-1.12.2-2.4.19.214-universal.jar buildcraft-all-7.99.24.8.jar carryon-1.12.2-1.12.4.16.jar cc-tweaked-1.12.2-1.89.2.jar Chameleon-1.12-4.1.3.jar ChickenChunks-1.12.2-2.4.2.74-universal.jar Chisel-MC1.12.2-1.0.2.45.jar Chocolate_Quest_Repoured-1.12.2-2.1.3B.jar Clumps-3.1.2.jar CodeChickenLib-1.12.2-3.2.3.358-universal.jar CoFHCore-1.12.2-4.6.6.1-universal.jar CoFHWorld-1.12.2-1.4.0.1-universal.jar CommonCapabilities-1.12.2-2.4.8.jar compactmachines3-1.12.2-3.0.18-b278.jar conarm-1.12.2-1.2.5.10.jar ContainerFix+MC1.12.2+v1.0.jar coroutil-1.12.1-1.2.37.jar CraftTweaker2-1.12-4.1.20.655.jar CTM-MC1.12.2-1.0.2.31.jar CustomMobSpawner-3.11.5.jar CyclopsCore-1.12.2-1.6.7.jar DeathCompass-0.0.3.jar Decocraft-2.6.3.7_1.12.2.jar diethopper-1.1.jar Draconic-Evolution-1.12.2-2.3.27.353-universal.jar DrZharks+MoCreatures+Mod-12.0.5.jar ElectroMagicToolsIC2C-1.12.2-0.0.8-11.jar EnderCore-1.12.2-0.5.76.jar EnderIO-1.12.2-5.3.70.jar EnderStorage-1.12.2-2.4.6.137-universal.jar EnergyControl-1.12.2-0.1.15.jar energyconverters_1.12.2-1.3.7.30.jar ExtraCells-1.12.2-2.6.5.jar ExtraPlanets-1.12.2-0.7.3.jar ExtraRails-1.12-1.3.0.jar extrautils2-1.12-1.9.9.jar ExtremeReactors-1.12.2-0.4.5.68.jar FarmingForBlockheads_1.12.2-3.1.28.jar FastFurnace-1.12.2-1.3.1.jar FastWorkbench-1.12.2-1.7.3.jar fencejumper-1.12-1.0.5.jar flatcoloredblocks-mc1.12-6.8.jar foamfix-0.10.14-1.12.2.jar forestry_1.12.2-5.8.2.422.jar Forgelin-1.8.4.jar ForgeMultipart-1.12.2-2.6.2.83-universal.jar FTBBackups-1.1.0.1.jar FTBLib-5.4.7.2.jar FTBUtilities-5.4.1.131.jar funky-locomotion-1.12.2-1.1.2.jar furniture-6.3.1-1.12.2.jar Galacticraft-Planets-1.12.2-4.0.2.280.jar GalacticraftCore-1.12.2-4.0.2.280.jar gravisuit-1.0.8.4.jar GTClassic-1.1.6.jar GunpowderLib-1.12.2-1.1.jar Hats-1.12.2-7.1.1.jar Hwyla-1.8.26-B41_1.12.2.jar IC2CExtras-1.4.8.3.jar IC2Classic+1.12-1.5.5.2.1.jar iChunUtil-1.12.2-7.2.2.jar industrialforegoing-1.12.2-1.12.13-237.jar IntegrationForegoing-1.12.2-1.11.jar InventoryTweaks-1.64+dev.151.jar ironchest-1.12.2-7.0.72.847.jar IvToolkit-1.3.3-1.12.jar JAOPCA-1.12.2-2.2.8.105.jar jeiintegration_1.12.2-1.6.0.jar jei_1.12.2-4.16.1.302.jar journeymap-1.12.2-5.7.1.jar LibraryEx-1.12.2-1.2.2.jar llibrary-1.7.20-1.12.2.jar LootBags-1.12.2-2.5.8.5.jar Mantle-1.12-1.3.3.55.jar mcjtylib-1.12-3.5.4.jar Mekanism-1.12.2-9.8.3.390.jar MicdoodleCore-1.12.2-4.0.2.280.jar minecolonies-1.12.2-0.11.841-ALPHA-universal.jar MJRLegendsLib-1.12.2-1.2.1.jar MmmMmmMmmMmm-1.12-1.14 modtweaker-4.0.20.4.jar Morpheus-1.12.2-3.5.106.jar MrTJPCore-1.12.2-2.1.4.43-universal.jar MTLib-3.0.7.jar mystcraft-1.12.2-0.13.7.06.jar natura-1.12.2-4.3.2.69.jar NetherEx-1.12.2-2.2.5.jar NetherPortalFix_1.12.1-5.3.17.jar NoMoreRecipeConflict-0.13(1.12.2).jar noRecipeBook_v1.2.2formc1.12.2.jar NotEnoughIDs-1.5.4.4.jar Nutrition-1.12.2-4.7.0.jar OpenBlocks-1.12.2-1.8.1.jar OpenModsLib-1.12.2-0.12.2.jar oreberries-1.12.x-0.5.0.jar p455w0rdslib-1.12.2-2.3.161.jar Pam's+HarvestCraft+1.12.2zg.jar Patchouli-1.0-23.6.jar platforms-1.12.0-1.4.6.jar PlayerAPI-1.12.1-1.0.jar plustic-8.0.3.jar PortalGun-1.12.2-7.1.0.jar ProjectRed-1.12.2-4.9.4.120-Base.jar ProjectRed-1.12.2-4.9.4.120-compat.jar ProjectRed-1.12.2-4.9.4.120-fabrication.jar ProjectRed-1.12.2-4.9.4.120-integration.jar ProjectRed-1.12.2-4.9.4.120-lighting.jar ProjectRed-1.12.2-4.9.4.120-mechanical.jar ProjectRed-1.12.2-4.9.4.120-world.jar PTRLib-1.0.5.jar QuantumStorage-1.12-4.7.0.jar Quark-r1.6-179.jar QuickLeafDecay-MC1.12.1-1.2.4.jar railcraft-12.0.0.jar randompatches-1.12.2-1.22.1.10.jar RebornCore-1.12.2-3.19.5-universal.jar RedstoneFlux-1.12-2.1.1.1-universal.jar Reliquary-1.12.2-1.3.4.796.jar Scannable-MC1.12.2-1.6.3.26.jar server.AIImprovements-1.12-0.0.1b3.jar server.Chunk+Pregenerator-V1.12-2.5.0.jar server.spatialservermod-1.3.1.jar ShadowMC-1.12-3.8.0.jar shetiphiancore-1.12.0-3.5.9.jar slideemall-1.03.jar Snad-1.12.1-1.7.09.16a.jar SpiceOfLife-mc1.12-1.3.12.jar StevesCarts-1.12.2-2.4.32.137.jar stg-1.12.2-1.2.3.jar StorageDrawers-1.12.2-5.4.2.jar StorageDrawersExtras-1.12-3.1.0.jar structurize-1.12.2-0.10.277-RELEASE.jar supersoundmuffler-revived_1.12.2_1.0.2.10.jar TConstruct-1.12.2-2.13.0.183.jar tellme-1.12.2-0.7.0-dev.20200919.184303.jar terraqueous-1.12.2-1.4.17b.jar tesla-core-lib-1.12.2-1.0.17.jar Thaumcraft-1.12.2-6.1.BETA26.jar thaumicenergistics-2.2.4.jar ThaumicInventoryScanning_1.12.2-2.0.10.jar ThermalDynamics-1.12.2-2.5.6.1-universal.jar ThermalFoundation-1.12.2-2.6.7.1-universal.jar TinkerToolLeveling-1.12.2-1.1.0.jar tombstone-4.4.4-1.12.2.jar Translocators-1.12.2-2.5.2.81-universal.jar Triumph-1.12.2-3.19.2.jar tropicraft-MC1.12.2-7.1.9.115.jar tumbleweed-1.12-0.4.7.jar twilightforest-1.12.2-3.11.1021-universal.jar UndergroundBiomesConstructs-1.12-1.3.8.jar UniDict-1.12.2-3.0.8.jar Uppers-0.0.6.jar ViesCraft-1.12.2-5.9.16.jar WanionLib-1.12.2-2.5.jar Wawla-1.12.2-2.6.275.jar Waystones_1.12.2-4.1.0.jar WeissCore-1.12.2-0.1.1-16.jar WirelessCraftingTerminal-1.12.2-3.12.97.jar WR-CBE-1.12.2-2.3.2.33-universal.jar WrapUp-1.12-1.1.3.jar Xtones-1.2.2.jar zerocore-1.12.2-0.1.2.9.jar zombieawareness-1.12.1-1.11.16.jar [1.12.2]+SecurityCraft+v1.8.22.2.jar ```
TheSnowyChickens commented 2 years ago

I can confirm this with Underground Biomes and falling entities.

SakuraWuhen commented 2 years ago

I have the same problem in TFC, the blocks will be replaced with random blocks, even directly displayed as air, but right click will return to normal

The current test found that using jeid version 1.0.3-50 and below can avoid the problem

OjGrooms commented 2 years ago

Had this issue with ONLY Biomes'o'plenty and JEID installed in a server. JEID breaks something in the biome gen, without any clear way to solve it.

How to reproduce: Run forge server MC 1.12.2 with BOP and JEID. Set level-type to BIOMESOP. Join world from client with the same version of BOP and JEID. Check the F3 info and fly around. Biomes will look like they are trying to generate properly, but any features (trees, plants, biome specific mobs and creatures) will not generate correctly. Either it will spit out random biome names as you fly around, or will only say 'Plains'. As far as falling block issues went, I did not test for it as my concern was the bad biome generation.

KirinFuji commented 2 years ago

Nice find, I also was using BIOMESOP world generator type which certainly explains the biome id issues. As for the rendering of falling entities, I suspect the client and server have mismatched ids for the falling blocks leading to a client side desync until it reforms as a normal block.