search

DimensionalDevelopment / JustEnoughIDs

Use the 1.13 chunk format in 1.12 to remove the block, item, and biome ID limits
MIT License
31 stars 33 forks source link

Conflict with Antique Atlas #27

Closed corgiblu closed 5 years ago

corgiblu commented 6 years ago

Seems to conflict with antique atlas. all the biomes show as deserts. other than water, that still shows as water.

with jeid and atlas 2018-08-01_23 10 04 without jeid 2018-08-01_23 10 12

for now i'll be hoping i won't need to add notenoughid's (custom pack so i need to be able to remove mods). or maybe you could add a config to disable parts of the mod.

crazyirishwrencher commented 6 years ago

Same issue.

justinrusso commented 5 years ago

Was this an existing world? Were these pre-mapped areas? Through testing I've found:

  1. Biome IDs shift with JEID. This means that with Antique Atlas' terribly old system for storing the texture map (pairing a texture type to a biome), biomes now have a different texture for newly mapped areas.
  2. If this is with a fresh antique atlas config, I would assume that maybe it's not getting the proper data anymore for the biome to "guess" what type of biome it is and pair it with a texture type.

Really, this is Antique Atlas' issue in my eyes, but if JEID can prevent the ID shift to retain backwards compatibility for existing worlds, it's better than nothing.

Since you're starting fresh, I may recommend moving away from Antique Atlas until they update their biome texture mapping method. It creates massive headaches for pack devs as once you have the pack out, you are unable to add a new biome to your world PERIOD unless you decide to screw over anyone with an existing world. You can see https://github.com/AntiqueAtlasTeam/AntiqueAtlas/pull/161 - I initially tried to fix this issue, but once I realized the scope of things that needed changing, it became something out of my knowledge of Java/Minecraft.

crazyirishwrencher commented 5 years ago

This happened even in a new world. Thank you for taking the time and effort to give a very thorough explanation, it is much appreciated.

On Mon, Nov 12, 2018, 10:20 PM Justin Russo <notifications@github.com wrote:

Was this an existing world? Were these pre-mapped areas? Through testing I've found:

  1. Biome IDs shift with JEID. This means that with Antique Atlas' terribly old system for storing the texture map (pairing a texture type to a biome), biomes now have a different texture for newly mapped areas.
  2. If this is with a fresh antique atlas config, I would assume that maybe it's not getting the proper data anymore for the biome to "guess" what type of biome it is and pair it with a texture type.

Really, this is Antique Atlas' issue in my eyes, but if JEID can prevent the ID shift to retain backwards compatibility for existing worlds, it's better than nothing.

Since you're starting fresh, I may recommend moving away from Antique Atlas until they update their biome texture mapping method. It creates massive headaches for pack devs as once you have the pack out, you are unable to add a new biome to your world PERIOD unless you decide to screw over anyone with an existing world.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DimensionalDevelopment/JustEnoughIDs/issues/27#issuecomment-438117977, or mute the thread https://github.com/notifications/unsubscribe-auth/AgibBV8HpeknlYn5P67vZvNqBECYsTwYks5uujp_gaJpZM4Vrj-q .

justinrusso commented 5 years ago

Sounds like the code used to determine the biome "type" breaks with something JEID does. Possible JEID to blame on that... not sure. Either way - you can modify these in the config it generates.

corgiblu commented 5 years ago

What do you mean "modify it in the config it generates"? If you mean changing the biome ids in the antique Atlas config, that doesn't work. Or at least it didn't work when I originally reported this.

On Tue, Nov 13, 2018, 10:10 PM Justin Russo notifications@github.com wrote:

Sounds like the code used to determine the biome "type" breaks with something JEID does. Possible JEID to blame on that... not sure. Either way

  • you can modify these in the config it generates.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DimensionalDevelopment/JustEnoughIDs/issues/27#issuecomment-438521963, or mute the thread https://github.com/notifications/unsubscribe-auth/AfIZLrZsLK1udWUNS6BbVJQ1VubB04ODks5uu4mSgaJpZM4Vrj-q .

ZombieHDGaming commented 5 years ago

Also seems like it has been fixed on their end. If it hasn't been fixed, please let me know and I'll reopen this issue.