search

DimensionalDevelopment / JustEnoughIDs

Use the 1.13 chunk format in 1.12 to remove the block, item, and biome ID limits
MIT License
31 stars 33 forks source link

Expand potion and enchantment IDs #6

Closed Sunconure11 closed 5 years ago

Sunconure11 commented 6 years ago

Unless those were taken care of, I don't see any code relating to them.

PulseBeat02 commented 6 years ago

I also would like this enchancement.

PulseBeat02 commented 6 years ago

Sadly it is actually not possible to extend potion ID's (I just found out) SPacketEntityEffect sends the ID as a byte, allowing only 256 ID's available.

Runemoro commented 6 years ago

That's not a problem. JEID will modify the packet to send it as an int. JEID already does the same for chunk update packets since vanilla Minecraft sends biome IDs as bytes too.

Sunconure11 commented 6 years ago

Wait, I remember discussing packets regarding a different mod in the past. Is it possible to extend the type of packet it is calling for in this error?

https://user-images.githubusercontent.com/5614902/42818207-3cc93d1e-899e-11e8-9f13-0f9fa3a14d6b.png

The mod causing this one in question is Howling Moon. I was never able to find the cause, and sort of gave up.

0Navis0 commented 5 years ago

It would be awesome if all the new code features and fixes of 1.13 could be included in JEID and VanillaFix.

ZombieHDGaming commented 5 years ago

Fucking finally done. Both will be released in the next release which is being reviewed atm.