search

DimensionalDevelopment / JustEnoughIDs

Use the 1.13 chunk format in 1.12 to remove the block, item, and biome ID limits
MIT License
31 stars 33 forks source link

Fix mod incompatibility with mods that redirect generateChunk. #79

Closed Zidane closed 5 years ago

Zidane commented 5 years ago

Since NotEnoughIDs isn't changing generateChunk and, instead, is only changing the biome array, we can safely inject afterwards.

Addresses incompatibility with SpongeForge.

Signed-off-by: Chris Sanders zidane@spongepowered.org

Zidane commented 5 years ago

Just to clarify a bit, the problem was exposed because we're trying to continue to prune our overwrites to a minimum (as overwrites add a lot more maintenance on our end and have burned us badly in the past when moving between Minecraft major versions). SpongeForge redirects the generateChunk call and so do you folks but we happen to have a higher priority so yours gets removed from being called. This addresses this so that both mods are happy.

Zidane commented 5 years ago

Found a possible issue, one sec (don't merge quite yet).

Zidane commented 5 years ago

There we go, good to go now.

Runemoro commented 5 years ago

Thanks!