search

DimensionalDevelopment / Rift

A lightweight mod loader and API for Minecraft 1.13
MIT License
122 stars 50 forks source link

Access transformation for inner classes #27

Open 0f-0b opened 6 years ago

0f-0b commented 6 years ago

Minecraft version: 1.13 Rift version: 1.0.4-52

The bug

When trying to change the visibility of any inner class, the access transformer only transforms the class, but does not change any visibility information in the outer class. So accessing the inner class is still a compile-time error.

How to reproduce

  1. In _accesstransformations.at, add this line: public class wu$a.
  2. Run gradle setupDevWorkspace --rerun-tasks.
  3. Try to access net.minecraft.tags.BlockTags.Wrapper (create a new instance, for example).
UpcraftLP commented 6 years ago

can confirm, same for this line that's already in rift: https://github.com/DimensionalDevelopment/Rift/blob/4234dcd9a4ad120fd00f48b0a7528df7cb562476/src/main/resources/access_transformations.at#L30