search

DimensionalDevelopment / Rift

A lightweight mod loader and API for Minecraft 1.13
MIT License
122 stars 50 forks source link

Add support for loading mods in 1.13 subdirectory #43

Closed ghost closed 6 years ago

UpcraftLP commented 6 years ago

Could this pull the mc version from MC itself instead of hardcoding it? (so it doesn't break in newer versions)

ghost commented 6 years ago

I think Rift should have a constants class in general that includes the Rift version as well as the Minecraft version. Currently, 1.13 is also hardcoded in the Main class. However, I think that goes beyond the scope of this PR.

Runemoro commented 6 years ago

The problem with this is that Rift for 1.13 mods will still be loaded in 1.13.1, and possibly even 1.14 if there aren't too many breaking changes. People wouldn't know if they should place a 1.13 mod they want to load on 1.13.1 in the 1.13 folder (because it's a 1.13 mod) or the 1.13.1 folder (because they want it to be loaded in 1.13.1).

Determining whether a mod is outdated or not should be instead done with a field in riftmod.json. Mods that are outdated but for which compatibility with the new version is possible will be remapped, transformed, and loaded, while those that are too outdated will be ignored (with a warning message to the player about the mod being too outdated).

ghost commented 6 years ago

Makes sense. In that case, what about a folder/subfolder specifically for Rift mods? The main reason I PR'ed this was this (quoted from #rift-support on Discord):

support for doing this with rift like you can do it with every forge version when tbh dont want to put it in the main directory because forge will load it into the classpath on 1.12

Runemoro commented 6 years ago

tbh dont want to put it in the main directory because forge will load it into the classpath on 1.12

Why not just set a different game directory? That way you make sure everything is separate, including the config folder.

Another option would be making the mods (and config) directory locations configurable, possibly through a command line option (which can be easily added in the Minecraft launcher).

kierajreed commented 6 years ago

I think mod subdirectories are good, but a command line option would be great too. That way all users are happy.

UpcraftLP commented 6 years ago

Another option would be making the mods (and config) directory locations configurable, possibly through a command line option (which can be easily added in the Minecraft launcher).

Looks like we'll end up having a mod list format like the one forge introduced :P