search

DimensionalDevelopment / VanillaFix

Minecraft mod that fixes Vanilla bugs, improves performance, and makes Minecraft run forever
MIT License
174 stars 53 forks source link

Vanillafix crashes on Vivecraft #117

Open blubbll opened 6 years ago

blubbll commented 6 years ago

https://bpaste.net/show/5189ec40a1bd

ZombieHDGaming commented 6 years ago

For one, Forge Mod Loader version 14.23.1.2559 you are using an EXTREMELY outdated version of Forge which could be an issue and causing VF to not find a specific method that we need. Maybe update to the latest 1.12.2 - 14.23.4.2705. Secondly, I know Vivecraft does some very invasive things to both Vanilla and Forge, so I don't even know if we would be able to support Vivecraft, but let's start with issue number 1 and go from there.

blubbll commented 6 years ago

updated to the latest forge version, the game itself works, but crashes at first start and doesn't load into vr when restarted(continued) using vanillafix

ZombieHDGaming commented 6 years ago

I'm not sure if there's much we can do about Vivecraft honestly. As far as I know, none of use at DimensionalDevelopment own a vive and can test against this. I'll do test builds and post them here so you can test them, but I may just need to add code to stop against VF from doing certain things while Vivecraft is installed.

blubbll commented 6 years ago

vivevraft also works for the oculus btw. here's a log on the latest forge with no other mods than vanillafix: https://bpaste.net/show/3ab8e0daba57

ZombieHDGaming commented 6 years ago

@blubbll It's still showing references to Vivecraft, even without it installed.........I think Vivecraft is doing a lot more than we realize here. I'll see about support when I push the new update. Give me a day or two and you can test the new release to see if it plays nicely, otherwise, there's not much I can do thanks to Vivecraft being so invasive to work.

blubbll commented 6 years ago

I'm using this version: https://github.com/jrbudda/Vivecraft_112 You can see what it changes and where it hooks into at the repo i guess. Amd thanks for trying to make vanillafix compatible with vivecraft :)

dennisheperol commented 6 years ago

Hello! I'm having the same problem with this mod while trying to play FoolCraft 3 + ViveCraft. If I remove VanillaFix everything works fine.

I myself am using https://riftcat.com/vridge to get VR using my phone. You can use VRidge 10 minutes freely (every session/not total) if you have an account. Maybe that could help you too to fix that bug?

ZombieHDGaming commented 6 years ago

VanillaFix-1.0.10-SNAPSHOT.zip @blubbll and @dennisheperol try this build out and let me know.

Techjar commented 6 years ago

@ZombieHDGaming Mind telling us what's changed in that build? If you're disabling stuff to support Vivecraft, I'd rather see if we can fix this on our end.

ZombieHDGaming commented 6 years ago

A list of things that will be saved for a release changelog. Atm, I'm just worried about whether the build works with it or not.

Edit: and I'm not disabling anything, I'm merely seeing if something that I had already done solves the issue.

Techjar commented 6 years ago

Seems to work. Game started up successfully and VanillaFix is loaded.

blubbll commented 6 years ago

https://paste.dimdev.org/anukameqov.mccrash always sends me back to a new error screen, when i click "back to title" and steamvr stays blank.

dennisheperol commented 6 years ago

https://paste.dimdev.org/zutudehizu.mccrash I'm having the same problem yes. It might be because Vivecraft is loading in a world when you start in the menu which causes problems because VanillaFix removes textures that should not be visible?

blubbll commented 6 years ago

maybe this fix should then be loaded only when necessary (when inside a world). always, or only when vivecraft is detected.