search

DimensionalDevelopment / VanillaFix

Minecraft mod that fixes Vanilla bugs, improves performance, and makes Minecraft run forever
MIT License
174 stars 54 forks source link

incompatible with ViesCraft #204

Open tril0byte opened 5 years ago

tril0byte commented 5 years ago

Forge 1.12.2-14.23.5.2836 with a bunch of mods loaded including ViesCraft (Airships) along with VanillaFix.

Symptom: When flying in an airship, rubberbanding, along with server message has moved wrongly!

Same symptom as when using RandomPatches with default settings.

Editing VanillaFix config to B:bugFixes=false doesn't help.

Request config option like RandomPatches to increase vehicle speed limits when using this mod.

ZombieHDGaming commented 5 years ago

I mean, there's nothing really we can do about this. RandomPatches already has an option in place for it, and if it doesn't work, no real point in us implementing it.

I will, however, recommend taking a look at this mod, "Gotta Go Fast", which can do essentially what you are looking for in a nice little addition mod.

tril0byte commented 5 years ago

Not sure I was clear. When using ViesCraft with RandomPatches to increase the fly speed, the airships work properly.

If I add VanillaFix, it undoes the effect of RandomPatches and makes the airships rubberband and I found no way to make the airship usable except to disable VanillaFix entirely. I don't want VanillaFix to add any feature for increasing speed, I would like it to stop breaking my existing setup. I request a config option to disable whatever part of VanillaFix is overriding RandomPatches so that I can use the other features of VanillaFix.

Runemoro commented 5 years ago

So the incompatibility is with Random Patches, not ViesCraft. Can you also report this to RandomPatches, since it's their patch that breaks, not ours?

Gunner76th commented 4 years ago

@Runemoro I believe you are confused on what he is saying. I'll attempt to break this down Army style so there is less confusion. 1) When using ViesCraft with RandomPatches the user is able to make a config setting which prevents the "Moved Wrongly" and rubberbanding issues 2) When using ViesCraft with VanillaFix the user is UNABLE to make the required changes to prevent the "Moved Wrongly" message in the console. 3) When using ViewsCraft with RandomPatches (and using the above mentioned changes in Item 1) as well as using VanillaFix on the same system, the changes being made by RandomPatches is being overridden by VanillaFix.

I believe this issue is directly related to this issue https://github.com/DimensionalDevelopment/VanillaFix/issues/16 in which you are using the Overwrite method instead of the inject or redirect methods. Your mod is directly overwriting settings from other mods, which it should not be doing, or there should be the ability to tell VanillaFix to not mess with changes made by certain mods (perhaps make it so that users can define a list). So as @tril0byte was trying to state, the issue is with VanillaFix messing with things and reverting/overwriting changes that it should not be doing. RandomPatches is fixing an issue, and VanillaFix is going behind it and breaking things.

Runemoro commented 4 years ago

@Gunner76th I know, which is why I said that the incompatibility is between VanillaFix and RandomPatches, not between VanillaFix and ViesCraft (RandomPatches breaks with VanillaFix installed, ViesCraft not working properly is only a consequence of RandomPatches breaking).

All overwrites being used are necessary since they completely replace the target method with custom code. Not that they have anything to do with this issue since they're rendering-related.

This issue should be reported to RandomPatches. With bugFixes disabled, VanillaFix only affects rendering and crash code, which shouldn't affect whatever RandomPatches is doing to the movement code.