search

DimensionalDevelopment / VanillaFix

Minecraft mod that fixes Vanilla bugs, improves performance, and makes Minecraft run forever
MIT License
174 stars 54 forks source link

Don't forcibly set fml.coreMods.load #30

Closed Aaron1011 closed 6 years ago

Aaron1011 commented 6 years ago

In VanillaFix's build.gradle, the fml.coreMods.load property is forcibly set. Because this takes place in GradleStartCommon, this has the effect of overwriting any changes made to fml.coreMods.load through the developer's IDE.

Additionally, https://github.com/MinecraftForge/ForgeGradle/issues/504 effectively causes this to apply to all modules in an IDE (e.g. Intellij) project.

The combination of these two issues makes it very difficult to run VanillaFix and any other coremod (e.g. SpongeForge). It would be helpful if VanillaFix didn't forcibly set this system property, allowing the developer to customize it as needed.

Runemoro commented 6 years ago

Done, I'm now setting the argument for runs generated by genIntellijRuns only.