search

DimiDimit / Custom-LAN

Minecraft Fabric mod that gives you more control over your integrated server through the Open to LAN menu.
https://modrinth.com/mod/custom-lan
MIT License
16 stars 8 forks source link

support 1.18.2 #16

Closed superloach closed 2 years ago

superloach commented 2 years ago

Swapped DynamicRegistryManager.Impl for the new DynamicRegistryManager.ImmutableImpl, since the previous Impl was an immutable one, and it built successfully. Haven't tested too extensively, but it does work!

Should close #15.

juster-0 commented 2 years ago

Have you tried to play with it? I can open minecraft with this build, but the game crashes every time when I try to open any world.

Minecraft: 1.18.2
MultiMC: 0.6.15-3244
Fabric API: 0.48.0+1.18.2
Mod Menu: 3.1.0
Fabric Loader: 0.13.3
superloach commented 2 years ago

Do you have crash logs? I didn't actually test too much 😅

juster-0 commented 2 years ago

Yep. Can you check? Crash Log

superloach commented 2 years ago

Looks like there's a type mismatch on the PlayerManager.LOGGER field, they switched from log4j to sfl4j in 1.18.2. I'll see if I can fix this later when I get home.

juster-0 commented 2 years ago

I've found fork with working 1.18.2 version, I've not tested fully, but Open to LAN and /op /deop commands and changing port work, so I think we can just open pull request from the fork.

superloach commented 2 years ago

Yeah, that fork looks good. I'll close this PR, @DimiDimit will you check out that fork and merge if you find it acceptable?