Combine efforts with create-react-library CLI?

DimiMikadze / create-react-library

React NPM library starter kit based on Facebook's create react app

MIT License

602 stars 60 forks source link

Combine efforts with create-react-library CLI? #27

Closed transitive-bullshit closed 6 years ago

transitive-bullshit commented 6 years ago

Hey @DimitriMikadze, I recently published a super simple CLI called create-react-library for bootstrapping new react libraries based on rollup and create-react-app.

I wasn't aware of this repo at the time lol. Any interest in combining our efforts?

I was thinking it'd be useful to have multiple templates in the CLI like if you wanted to use this repo's webpack setup instead of the default rollup config.

Lemme know && thanks!

DimiMikadze commented 6 years ago

Hi @transitive-bullshit

Sure, i just see we have taken totally different approaches taken, do you have any idea how we can combine them?

transitive-bullshit commented 6 years ago

Hey yeah, I think my response in the other thread definitely came off wrong. I'd love to join forces if we can figure it out!

Here's what I'm thinking:

I already have the create-react-library npm module and binary, which makes it easier to get started, but your boilerplate is really popular.
Maybe we could add an option during the CLI creation to choose between webpack vs rollup and use one or the other boilerplate accordingly under the hood?
I'm thinking once the user makes this choice once, it would be the default for them from then on by storing some user config state.

The one area I'm concerned with is keeping the template used in the CLI in sync with the boilerplate repo itself. I haven't figured out a clean way to do this yet with my original boilerplate, so if you have any ideas here, I'd love to hear them.

Thoughts?

DimiMikadze commented 6 years ago

@transitive-bullshit i would also love combining our efforts and i'm not into Webpack vs Rollup, by we have taken totally different approaches, i mean that you have built configuration of build tools by your own and i'm using exactly same configuration files, that CRA uses slightly edited.

Philosophy of this project is that to create React library using create react app, therefore if we'll add support for Rollup, that means we have to build all this configuration from scratch, because CRA uses Webpack for bundling scripts.

Because of this reason it's hard for me to see how we can merge this two libraries, but if you have idea how we can merge them without loosing their philosophy, (Using Rollup in your case and create library with CRA in my case) i'm totally into it.