search

DimiMikadze / create-react-library

React NPM library starter kit based on Facebook's create react app
MIT License
602 stars 60 forks source link

Fix relative URLs in CSS #30

Closed Bagera closed 6 years ago

Bagera commented 6 years ago

Fixes #26

DimiMikadze commented 6 years ago

HI @Bagera

Thanks for sending PR, can you confirm it's working in production environment? I mean after publishing to NPM and then installing in project

Bagera commented 6 years ago

No I can not. sorry. I have just used it with file:. That should be quite similar but I'm not 100% sure.

Bagera commented 6 years ago

I have a published lib on npm that you can try. kitty-lib with the component KittyCard. I had to add the build/css and build/media folders to the package.json files field as the files where otherwise omitted when you publish. I have tested kitty-lib in an app of mine and it works.

DimiMikadze commented 6 years ago

Hi @Bagera closing this PR, because of this PR: https://github.com/DimiMikadze/create-react-library/pull/33, would love your opinion on it

Bagera commented 6 years ago

@DimiMikadze That looks like a more complete as it also deals with the hash issue.