search

DimiMikadze / create-react-library

React NPM library starter kit based on Facebook's create react app
MIT License
602 stars 60 forks source link

Misleading media path on build #33

Closed joshuadeguzman closed 6 years ago

joshuadeguzman commented 6 years ago

Howdy, I have noticed a strange behaviour when building the project both for demo and production (when I uploaded my library in the registry), there has seem to be a configuration needed to be placed to fix the path vs the name (eg. @font url(../media/example.file) becomes @font(name) or @font(media/example.file) when compiled which is relatively incorrect when the browser tries to find the file.

DimiMikadze commented 6 years ago

Hi @jodeio

Thanks for sending PR, can you confirm it's working in production environment? I mean after publishing to NPM and then installing in project

joshuadeguzman commented 6 years ago

Yes Dimi, you can have it test using my library rappler-carouxel available on npm and use it on a sample project.