Push notices

[ericlewis]

This is a general issue to capture push notice ideas. These can all be done locally, but need to be based on the island time.

• [ ] when shops open / close
• [ ] special events (sprint fishing tourney)
• [x] turnip price changes
• [x] turnip sell reminder / turnip purchase reminder

[ericlewis]

We have at least one of these things!

[rohanrk]

Hi. Is anyone working on the first two notification categories? I'd like to take a stab at it if it's available

[adamrais]

Hello, i am also interested about working on this issue as a first contribution, specially the notification for when the shops open or close. Let me know if we can divide this or work on it together.

[rohanrk]

Hey I started on a branch on my fork. I'm mostly just reading through to make sure I understand the codebase but I'm down to contribute together. Not sure if there's a gitter or slack channel for the repo. Any preferred mode of communication?

[TheVaan]

Hi, thank you both for your interest in contributing.

Just a few thoughts about it: When adding notifications related to game time it would be good having an option in settings that controls wether game time is in sync with device time. With this information we also could control other time related content to be hidden. Add new section „Notifications“ to settings screen, where user can enable disable specific notifications. May hide the option to enable notifications that are time depending when „game time in sync“ setting is disabled (game time in sync setting would be best in the island setting section).

We discussed adding an option for defining a game time offset to calculate the game time, but we think that someone who changed game time will do this often and doesn’t want to update helper settings. Anyway, as a challenge you can try adding a „time offset“ option, but I think the effort isn’t worth the time to spend for this feature.

[rohanrk]

Following up on this, I'm going to work on special events. All the events are listed here. https://animalcrossing.fandom.com/wiki/Events_(New_Horizons).

I don't think all of these are worth notifying users about (e.g mushroom season). Do we want to make a list of the important special events to send push notifications for? It'll be easy enough to add a setting to toggle special event notifications

[adamrais]

Hello, the toggle button is already implemented, we just need to add the logic in notificationManager!

[Dimillian]

I think it’s worth to notify the user the first day the event start maybe ?!

[TheVaan]

I think long-time events should have a "today starts xy" and maybe also a "today ends xy" (or even "tomorrow ends xy", so the users have enough time to do stuff).