Add partial like in item with variants

Dimillian / ACHNBrowserUI

Animal Crossing New Horizon companion app in SwiftUI

Apache License 2.0

1.68k stars 182 forks source link

Closed renaudjenny closed 3 years ago

renaudjenny commented 3 years ago

Add an half star to show that the item has been partially completed, meaning at least one of its variants is liked, but not all of them.
Display bottom sheet variations if the item has variants instead of adding it to the collection without their variants.
Fix #230

renaudjenny commented 3 years ago

LOL I wanted to show a video recording of the result, but it's now impossible to upload video on GitHub :(

renaudjenny commented 3 years ago

Screen Recording 2020-12-28 at 15 07 16

Dimillian commented 3 years ago

I love the functionality and it works very good from the list, but it missing two things.

An animation when the bottom sheet is presented / dismissed.
When you're on the item detail screen, the favorite button in the navigation bar is doing nothing, it should also present this bottom sheet.

Appart from that, awesome!

renaudjenny commented 3 years ago

Hi @Dimillian, yes good idea, I will work on that today 🙂

renaudjenny commented 3 years ago

@Dimillian, animation is done, I really like it! Let me know if you do too 😁

Dimillian commented 3 years ago

Love it! LGTM!