Support for pages for filter and user

Dimillian / HackerSwifter

A Swift Hacker News library

MIT License

170 stars 32 forks source link

Support for pages for filter and user #5

Closed finder39 closed 10 years ago

finder39 commented 10 years ago

Added to be able to have "load more" on table view.

Determining whether more are available to load does not seem appropriate for api and will be done in SwiftHN.

finder39 commented 10 years ago

Also, I kept it all backwards compatible so nothing would break

Dimillian commented 10 years ago

Look good. 2 things

Can you indent it the same way other code is indented?
The default parameter for the page should be 0 for the backward compatibility. 1 is the next page.

Dimillian commented 10 years ago

Also, for the test, what I would do is, Fetch page 0, Fetch page 1, and compare the id of the first 2 posts of both array. They should not be equal. If this test pass, I'll merge :)

finder39 commented 10 years ago

I will fix the indenting now
As for the pages, hacker news is using page 1 as first and page 2 as second: https://news.ycombinator.com/news?p=1 https://news.ycombinator.com/news?p=2 p=0 and p=1 return the same thing, page 1

Dimillian commented 10 years ago

My bad sorry, I quickly tested, yeah, Page 0 & page 1 are the same. So it's fine :) Just fix the indentation, and a better test would be nice.