Dimillian / IceCubesApp

A SwiftUI Mastodon client
https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884
GNU Affero General Public License v3.0
4.95k stars 466 forks source link

Improve `StatusPollView` #1929

Closed thai-d-v closed 6 months ago

thai-d-v commented 6 months ago
  1. use Layout to remove GeometryReader
  2. fix inconsistent bars' height
  3. move the button image out of the bar to make it clear which bar is selected
  4. use relative percent for bars' width
    • more space-efficient, show the relative comparison between bars better
    • the "absolute percent" is already shown by the text on the right
  5. refactor code and tweak layout to make it more consistent with other views

image

Dimillian commented 6 months ago

You became the layout master. What about polls where the text is not fitting? Does it still go on 2 lines? (I think it should be)

thai-d-v commented 6 months ago

I hope this is OK.

image

Dimillian commented 6 months ago

Nice!