Dimillian / IceCubesApp

A SwiftUI Mastodon client
https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884
GNU Affero General Public License v3.0
4.95k stars 466 forks source link

Bug: Respect the allowed number of attachment in the instances api response #1943

Closed ileodo closed 5 months ago

ileodo commented 5 months ago

Environment:

Description

I understand by default, mastodon only allow 4 media attachments. however some instances might have vary setup. I believe that's why the instance endpoint has a field (max_media_attachments)[https://github.com/mastodon/mastodon/blob/1666b1955992e16f4605b414c6563ca25b3a3f18/app/serializers/rest/v1/instance_serializer.rb#L67] indicating the max number of media attachment supported by that instance.

So, shall we remove the hard coded 4 from this wonderful client, and just respect the number returned in the instance api request?

Related Issues

Dimillian commented 5 months ago

Good idea and done for next release!

ileodo commented 5 months ago

@Dimillian thanks for the rapid response on this! I think in the timeline view, each status will only show 4 attachment, would it possible to remove that restriction and leave it to the server to control it?

happy to create a separate issue to track it.

Dimillian commented 5 months ago

I'll fix it too

ileodo commented 5 months ago

awesome.. I'll definitely be a sponsor for this!!