Dimillian / IceCubesApp

A SwiftUI Mastodon client
https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884
GNU Affero General Public License v3.0
4.89k stars 461 forks source link

Cancel header edit #1956 #1991

Closed mdhsieh closed 3 months ago

mdhsieh commented 4 months ago

Environment:

Issue:

https://github.com/Dimillian/IceCubesApp/issues/1956 When editing a profile, the header and avatar are updated to whatever a user picks even when they cancel.

Causes:

Both header and avatar are immediately uploaded to the user's account the moment they pick an image.

Solution:

We can instead display a picked image temporarily, like a preview. The image is only uploaded once we save the profile.

The change'll look like this:

https://github.com/Dimillian/IceCubesApp/assets/52055110/bb227e09-c1ad-4899-b8a4-123954fdd8da