Bug: Changing Theme Breaks "Match System" Toggle Behaviour

Dimillian / IceCubesApp

A SwiftUI Mastodon client

https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884

GNU Affero General Public License v3.0

4.88k stars 460 forks source link

Bug: Changing Theme Breaks "Match System" Toggle Behaviour #1994

Open muhasturk opened 4 months ago

muhasturk commented 4 months ago

Environment:

OS: iOS 17.2
IceCubesApp: main branch on source code.

Description

Navigate Settings -> Display Settings
Change theme one that different from current scheme.
Re-enable "Match System" toggle
Now app won't listen system appearance changes unless application fully restarted.

Related Issues

hasn't been reported yet

muhasturk commented 4 months ago

If we would comment out following lines, the problem will be fixed. It will be better if we find out better way. Overriding interface style of windows breaks the "Match System"

https://github.com/Dimillian/IceCubesApp/blob/15d7d1dabdbc1a1b21dbd51dc70adf9624d2c319/Packages/DesignSystem/Sources/DesignSystem/ThemeApplier.swift#L52