Dimillian / IceCubesApp

A SwiftUI Mastodon client
https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884
GNU Affero General Public License v3.0
4.88k stars 460 forks source link

Improve deep link handling on cold start #2026

Closed nathreed closed 3 months ago

nathreed commented 3 months ago

Previously, if the app was not already running when the Safari action extension was used to open a post in the app, the post would open in the in-app Safari instead of using the Ice Cubes UI. The action extension only worked well if Ice Cubes was already running but backgrounded when it was used. This was because of the hasConnection(with:) check used to ensure that the current server has a federation relationship with the server the post is on. Early in app launch, the list of federated peers has not come back from the API request yet, so hasConnection(with:) was always returning false.

To fix, issue a request to fetch the peers as part of the URL handling process, before checking hasConnection(with:) to make the final navigation decision. As an optimization, only do this if hasConnection(with:) returns false initially -- if it returns true, we already know a connection exists so no need to check again.