Bug: PushSubscription.id should be a String

Dimillian / IceCubesApp

A SwiftUI Mastodon client

https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884

GNU Affero General Public License v3.0

4.88k stars 460 forks source link

Bug: PushSubscription.id should be a String #2050

Open dcwatson opened 2 months ago

dcwatson commented 2 months ago

Description

According to https://docs.joinmastodon.org/entities/WebPushSubscription/#id the PushSubscription ID is cast from an int, but should be a string. I'm implementing a server, and sending back an integer as a string causes IceCubes to not be able to set subscription options.

Related Issues

[x] Search that this bugs don't already exist before creating it.

Dimillian commented 2 months ago

Interesting, I'm not doing any custom decoding, so I guess it's just a bug in the Mastodon API and they won't change it since it would break many clients.

dcwatson commented 2 months ago

It's hard to tell what are bugs and what is just outdated documentation sometimes 😁 I'm going to change my server to send integers anyway, so do with this what you will!

Dimillian commented 2 months ago

Nice! I know it was causing some issues to some other Fediverse servers too, but this is a Mastodon client hehe