Dimillian / IceCubesApp

A SwiftUI Mastodon client
https://apps.apple.com/us/app/ice-cubes-for-mastodon/id6444915884
GNU Affero General Public License v3.0
5.56k stars 539 forks source link

Bug: Image download button not working on desktop. #2131

Open datawench opened 4 months ago

datawench commented 4 months ago

I've been using the ipad version for quite a while now, and am used to it. But I only recently decided to start using the desktop app. I see that when viewing an image I can use the "share" button to add it to the Photos library, but what does the little down arrow do, that I suppose must be a download button?

datawench commented 3 months ago

I've edited the title, because I've tracked this down a little and I think it's an issue. If I understand correctly, the "down arrow" on the popup image viewer uses the Swift function UIImageWriteToSavedPhotosAlbum() within the custom function saveImage() in the file Packages/MediaUI/Sources/MediaUI/MediaUIView.swift.

According to the documentation of the Swift function, it's supposed to write to the "camera roll" library, which on a Mac is just Photos. But it doesn't happen here. We can use the share button to get the photo into the Photos library. We can even drag/drop the photo out of the popup to anywhere we want (a happy discovery). But as far as I can tell, the download feature just doesn't work on a Mac... though I know it does in iOS.