Cache system sees Top and User as same

Dimillian / SwiftHN

A Hacker News reader in Swift

GNU General Public License v2.0

1.71k stars 282 forks source link

Cache system sees Top and User as same #13

Closed finder39 closed 10 years ago

finder39 commented 10 years ago

The cache sees the Top and User (and my guess would be others as well) as the same. So if you are loading page 1 of a user, it loads the page 1 from Top cache and then loads page 1 from user internet. I hope I said that in an understandable way.

I will reproduce this in a test soon

EDIT:

[x] Fix subclassing issue (this issue is not related to cache)

Dimillian commented 10 years ago

Whoops moved here

"Well caching for pages will be a lot rarer than for the top pagee so you can assume it would be really off and ignore it.

If you want to change that you may want to do a branch. I designed the cache system that way to have the app to always display content, so yeah even if you're online it'll display the cache first. But as background fetch is enabled, the cache will be off by an hour or so. I really like it that way, you don't want blank screen for a few sec when you are online. True it need to be handled in the UI that it refreshed 2 times, but I think it's fine."

Dimillian commented 10 years ago

Wait, this issue is not due to the cache, it's due to the subclassing mechanism I did for the view controller, It's because UserViewController subclass NewsViewController, there is a bug which load News post before user post (super viewDidLoad call) and I'll fix it

finder39 commented 10 years ago

ooooo gotcha :smile:

I'll leave this issue open and you can close it once that is fixed up.

The cache system I'm talking about is different. I'll create a a different issue for that as it's more of a change. I should learn to just start a conversation in the right place :stuck_out_tongue: