search

DimitriFourny / chromium_updater

Very simple Chromium updater for Windows.
2 stars 0 forks source link

Mixed content of Google Chrome and Chromium #1

Open woolyss opened 4 years ago

woolyss commented 4 years ago

Hello Dimitri,

I checked your code today. It is well written.

But there is a misunderstanding. Your tool mixes Google Chrome and Chromium content. So your tool is corrupted! :/

I explained that few months ago about a similar tool at https://github.com/cypress-io/chromium-downloads/issues/18

Hope this will help you to improve your work.

Regards

Your run.py file:

DimitriFourny commented 4 years ago

Hello, thank you for your message. The idea is just to know if your Chromium version is "far away" from the last Chrome version. It's why I let the user decide if he wants to update it or not.

woolyss commented 4 years ago

OK I see. Thank you.

In this case, just rename most of your functions because most of them gets info from Chrome development!

And I persist, you cannot say "Installed version(s): 80.0.3987.149" because the stable Chromium versions do absolutely not exist in the Chromium repositories (googleapis.com/download). So it should be better to rename it as "Chrome reference" or whatever.

Regards