search

DimmestP / chimera_project_manuscript

1 stars 2 forks source link

Tidy up the code for the construct plot tables #93

Open ewallace opened 3 years ago

ewallace commented 3 years ago

The code for the insertion and deletion construct plots is very hard to follow, in combine_terminator_construct_qPCR_and_design_figure.R, this part:

insertion_construct_plot <- wrap_elements(...)
deletion_construct_plot <- wrap_elements(...)

It would be easier if the tableGrob were constructed separately, to make an object insertion_construct_motif_table or something. That would reduce the number of layers that the user needs to keep in mind.

There might be some other layers that help to clear this up.

ewallace commented 3 years ago

Also, shouldn't we include the explicit motif in these tables, not the consensus motif?