search

DimonSE / open9x

Automatically exported from code.google.com/p/open9x
0 stars 0 forks source link

DSM2 range check function #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Lodging this as a separate to-do.

I've added DSM2 range check to the model SETUP menu and finally managed to get 
a warning tone happening when it's enabled.

TODO -- figure out how to turn off range check mode when the RANGE field or 
menu is exited, so that it can never be accidentally left on.

Original issue reported on code.google.com by gru...@gmail.com on 22 Aug 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
DSM2 range check mode completed.

However, I don't like that the only place I could find to turn off range check 
mode when the SETUP menus is exited, was in popMenu ...

void popMenu()
{
  if (g_menuStackPtr>0) {
#ifdef DSM2
    s_rangecheck_mode = 0;
#endif
    ...
}

It was the only way I could find to trap the event of [EXIT long] being pressed 
while in the RANGE field and s_editMode==true. But this solution gets executed
for all menu exits -- not just menuProcModels. It works, but there must be a
more eloquent method?

Original comment by gru...@gmail.com on 22 Aug 2012 at 7:09

GoogleCodeExporter commented 9 years ago

Original comment by gru...@gmail.com on 23 Aug 2012 at 1:53

GoogleCodeExporter commented 9 years ago 
Awaiting testing confirmation.

Original comment by gru...@gmail.com on 24 Aug 2012 at 3:11

GoogleCodeExporter commented 9 years ago 
I just ordered a DX4e DSMX transmitter from eBay. This should allow me to 
upgrade my DSM2 module to DSMX soon, for testing and general usage. Yay \o/

Original comment by gru...@gmail.com on 24 Aug 2012 at 3:12

GoogleCodeExporter commented 9 years ago 
This should all be working now, as of r1277. 

PLEASE NOTE that the DSM2 option 'LP4/LP, DSM2onl, DSMX' now _matters_. If you 
have a DSM2 receiver, you probably will not get it to work or bind when set to 
DSMX, for example.

In other words, a previous bug rendered this option almost completely 
inoperative, such that it didn't much matter what setting you used.

[Waiting on test report from André before marking this one Fixed.]

Original comment by gru...@gmail.com on 26 Aug 2012 at 11:51

GoogleCodeExporter commented 9 years ago 
Still waiting on stock board test results ... but it looks fine for me.

Original comment by gru...@gmail.com on 28 Aug 2012 at 12:44

GoogleCodeExporter commented 9 years ago 
André reported "all good" (thanks). Marking issue as Verified.

Original comment by gru...@gmail.com on 31 Aug 2012 at 10:55