Rot. Encoder Beep-Cntr not quite right

[GoogleCodeExporter]

Making some time to do more BETA testing (finally!)

What steps will reproduce the problem?
1. Set Beep-Cntr on for REa and/or REb
2. Enter DIAG screen as an additional visual aid (watch counters)
3. Note that ...

   a) The beep does not occur on the same count, but 
      rather one count either side of "centre". (The 
      number in DIAG for centre is arbitrary. Example,
      beep at 3 and 5 with 4 being silent.)

   b) It can be seen on the numeric channel output view that
      the beeps occur at -0.8 and +0.8, not at 0.0 as one would 
      expect.

   c) One needs to move at least three (3) clicks reverse
      away from the last beep before another centre-beep
      will be emitted.

What is the expected output? What do you see instead?
For rotary encoders, the center beep should be precisely on the same 'click' 
(indent) of rotation, in both directions, with no dead-band required for reset 
(no anti-hysteresis filtering.)

What version of the product are you using? On what operating system?
open9x r1197 on G9X v4.1 board. 

Please provide any additional information below.
I suspect that the exact same code or algorithm is being used for the encoder 
channels as is for the P1/2/3 inputs, where in the latter case the above 
behaviour would be required for a wanted anti-hysteresis effect. 

I suggest then, that the rotary encoders need to be exempt from any such 
filtering, instead using the raw channel data at 0.0 for centre detection, with 
no reset dead-band.

Thanks again.

Gruvin.

Original issue reported on code.google.com by gru...@gmail.com on 4 Aug 2012 at 11:34

[GoogleCodeExporter]

   d) If you continue rotating past the beep, then you must travel 
      a full five clicks before reversing back will produce any 
      center beep. (The relating reason is obvious, once you see 
      how it works.)

This is not trivial in my view -- except that center beeps themselves might be, 
some. :-P This issue pretty much renders the center beep completely useless for 
the rotary encoders. Hope it's an easy fix! :-D

Original comment by gru...@gmail.com on 4 Aug 2012 at 11:49

[GoogleCodeExporter]

Original comment by bson...@gmail.com on 16 Aug 2012 at 8:35

• Changed state: Fixed

[GoogleCodeExporter]

Would you check that I fixed the bug, the reason you gave was right (I don't 
have my gruvin Tx here...)

Original comment by bson...@gmail.com on 16 Aug 2012 at 8:38

[GoogleCodeExporter]

Tested OK r1220. RE's center working as it should and P1/2/3 not adversely 
affected.

Thanks.

Original comment by gru...@gmail.com on 17 Aug 2012 at 12:34

[GoogleCodeExporter]

Original comment by gru...@gmail.com on 28 Aug 2012 at 12:50

• Changed state: Verified