search

Dindaleon / hapi-react-starter-kit

A hapi React Starter kit with react-router, redux, react-transform
172 stars 29 forks source link

fix indent and codestyle #8

Closed zebapy closed 8 years ago

zebapy commented 8 years ago

Removed some tab characters and fixed spacing around props.

I'd recommend just sticking to no spaces around prop values (prop={something}) as that's more common, even if objects outside of JSX have spaces. It's an exception – just like using double quotes in JSX.

Also I noticed elsewhere that there is a mixture of self-closed components ending with a space before /> (this file) and some without the space (the server file).

I did this edit on Github so I'm not sure if the lint config specifies that or not.

Dindaleon commented 8 years ago

That is weird, it doesn't look like that on my editor. I am using Sublime Text. What do you think it might be causing it?

Thanks for pointing it out and fixing it. Are there other files with the same problem?

I do have lint configured to have spaces inside curly braces and parenthesis. I do not plan to change this as of now, but I will consider it for future releases.

The self closing components should all have an space before /> I see where doesn't have the space in the server file:

renderToString( <Html store={ store }/> )

Please let me know if there are more files missing the space.

I will fix it now.

zebapy commented 8 years ago

@Dindaleon I think you can set tabs display as a specific amount of spaces in some text editors. That's my only thought.

Dindaleon commented 8 years ago

Well, I will keep an eye open for future versions. I have mine set to two spaces indent.