Dindaleon / hapi-react-starter-kit

A hapi React Starter kit with react-router, redux, react-transform
172 stars 29 forks source link

Class property semi colons, more lint fixes #9

Closed zebapy closed 8 years ago

zebapy commented 8 years ago

Some more lint fixes and added semi colons for all class properties I got errors for.

I meant to sync this to the branch before you merged but you beat me to it :)

Dindaleon commented 8 years ago
zebapy commented 8 years ago
Dindaleon commented 8 years ago
zebapy commented 8 years ago

Sorry, are you sure you needed the bind created in that manner? :: vs fat arrows in the actual method. The bind is not removed. Simply the manner of how it is done is changed. I can revert it if you're interested in merging the rest of this, else just close it. Honestly this is the most I've publicly contributed on GitHub. I felt inspired to do a few things on this since I've switched my react app to use Hapi as a server since my API was already built in it, and this is the repo I found as an example.

Dindaleon commented 8 years ago

There was a misunderstanding. When I said "That bind was needed" I meant that your modification was the right way of doing it. Sorry.

I hope you continue your contribution :)

flying-sheep commented 8 years ago

6.5.2 has the semicolon thing reverted!

Dindaleon commented 8 years ago

Thank you for letting us know.