Dineshraj555 / pe

0 stars 0 forks source link

DG: Model component API: Model.java appears to be congested. #14

Open Dineshraj555 opened 2 years ago

Dineshraj555 commented 2 years ago

Screenshot 2022-04-16 at 3.37.00 PM.png

Diagram could be broken down further and simplified.

soc-pe-bot commented 2 years ago

Team's Response

First of all, the reason for breaking down diagrams is often because the original diagram is often too large and affects visibility. As per your screenshot, our diagram is perfectly visible, where the labels and words are large enough to read, there is no need to break the diagram down.

Secondly, the diagram is understandable from a high-level point of view (it only contains Book and Patron along with their attribute classes). Further simplifying the diagram will only increase the number of diagrams in the documentation and make the documentation more lengthy. It may also result in a loss of important information for the readers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I recall from tutorials that this diagram is deemed to be congested. Nevertheless I think it is very low severity.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]