DingBao-sys / pe

0 stars 0 forks source link

add command error message not clear in speicfying missing phone number #2

Open DingBao-sys opened 4 months ago

DingBao-sys commented 4 months ago

Steps to reproduce:

  1. add n/John Doehhhhhhdshdhdp/ilivehere e/johnd@example.com a/311, Clementi Ave2, #02-25 b/25/2/2024 s/Female

expected: error message saying missing compulsory phone number

actual: Invalid command format! add: Adds a patient to the list. Parameters: n/NAME p/PHONE e/EMAIL a/ADDRESS b/DATE OF BIRTH s/Sex Example: add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 b/25/2/2024 s/Male

Screenshot 2024-04-19 at 4.30.33 PM.png

likewise for missing name

soc-pe-bot commented 4 months ago

Team's Response

We believe the error message is specific enough. There aren't that many possible reasons that can return this error message. If each field does not satisfy the conditions, they will show their error messages.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]