search

Dingf / GDCommunityLauncher

The launcher for the Grim Dawn Community League project
MIT License
1 stars 2 forks source link

Server Sync/Concurrency #2

Closed 12foo closed 1 year ago

12foo commented 1 year ago

Should help a bit with #1 . I playtested it for a couple hours and no problems. Basically since we're only building for Windows, we can use the Windows-provided PPL functions and don't need to rely on the stripped-down PPLX inside the REST SDK. PPL offers a task group that we can just put background tasks onto to be managed, so we don't need to deal with any concurrency issues aside from using continuations.

12foo commented 1 year ago

Found some other people on the Discord who were ahving similar problems, and I realized it's more widespread than I thought. Might also be causing some of the chat outages people have been reporting. Amending the PR in a bit.

Dingf commented 1 year ago

Looks good, I don't have any other comments so just let me know when you've finished up with your changes.

12foo commented 1 year ago

One of the testers still had one freeze occur after a few hours of playing (but down from freezing regularly), so I probably missed a spot somewhere. I'll try and see if I can find it.