DinhSonFE / df-frontend-2023

https://df-frontend-2023-mu.vercel.app
0 stars 0 forks source link

Submission for assignment 1 #1 #1

Open DinhSonFE opened 1 year ago

DinhSonFE commented 1 year ago

Website Link : https://df-frontend-2023-mu.vercel.app/

Bookstore features : -Search by title: Users can enter the title of a book into the search bar to find that book in the bookstore. -Add new books to the bookstore: Users can add new books to the bookstore -Delete books from the bookstore: Users can delete books from the bookstore by clicking the delete button next to the book. -All books are stored in local storage: All books in the bookstore are stored in the user's browser's local storage. This means that the books will still be there even if the user closes the website.

trankhacvy commented 1 year ago

Hello @DinhSonFE , well done!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Your code could benefit from better formatting. You can make it more organized either by manually improving its structure or by using the formatting tools in your IDE.

  2. Splitting your script into multiple files and using module loading is a great idea, but it might seem a bit too complex for this assignment. Nevertheless, it's still a good idea.

  3. Think about putting the JSON.parse function inside a try-catch block. This way, you can handle unexpected errors more gracefully.

  4. Animation adds value to a website, but if you use it too much, it might make users uncomfortable. Your loading animation might be a bit excessive.

Keep up the good work!