search

DinhSonFE / df-frontend-2023

https://df-frontend-2023-mu.vercel.app
0 stars 0 forks source link

Submission for assignment 3 #3 #3

Open DinhSonFE opened 1 year ago

DinhSonFE commented 1 year ago

Website Link : https://df-frontend-2023-u893.vercel.app/ Bookstore features : -Search by title: Users can enter the title of a book into the search bar to find that book in the bookstore. -Add new books to the bookstore: Users can add new books to the bookstore -Delete books from the bookstore: Users can delete books from the bookstore by clicking the delete button next to the book. -All books are stored in local storage: All books in the bookstore are stored in the user's browser's local storage. This means that the books will still be there even if the user closes the website. -Pagination : Pagination by book list. Each page will have 5 products. You can view the products of each page -Change theme dark or light : Users can toggle between light and dark mode to suit their preference. The theme is saved locally, so users will always be greeted by their preferred interface upon returning to the website.

Thank you for reviewing my article. I appreciate any feedback you can provide, as it will help me improve.

trankhacvy commented 1 year ago

Hello @DinhSonFE , well done!

Requirements

Final result: ✅ Passed

Feedback

We also have some comments for your work:

  1. Some functions don't have types. If you turn on the noImplicitAny setting, you can easily find them. Think about adding types to them.

https://github.com/DinhSonFE/df-frontend-2023/blob/79a75fa7f82d4f9840ab5b3fc0ce77fef8381c79/assignment-3/src/components/TableBook.tsx#L54C14-L54C14

https://github.com/DinhSonFE/df-frontend-2023/blob/79a75fa7f82d4f9840ab5b3fc0ce77fef8381c79/assignment-3/src/components/SearchBook.tsx#L15

  1. I suggest using TBook instead of TBookList.

https://github.com/DinhSonFE/df-frontend-2023/blob/79a75fa7f82d4f9840ab5b3fc0ce77fef8381c79/assignment-3/src/reducers/initialSate/initialStateTypes.d.ts#L17

  1. Since the placeholder is already a string, there's no need to enclose it in `${}``.

https://github.com/DinhSonFE/df-frontend-2023/blob/79a75fa7f82d4f9840ab5b3fc0ce77fef8381c79/assignment-3/src/components/Input.tsx#L31

  1. There are some issues and bug that I pointed out in the previous assignment, and they haven't been addressed in this assignment. Please take your time to fix these issues.