search

DinisCruz / Book_SecDevOps_Risk_Workflow

Content for 'JIRA Risk Project' book published at LeanPub
Apache License 2.0
55 stars 17 forks source link

Question on "In DevOps everything is Code" #73

Closed Ambg05 closed 7 years ago

Ambg05 commented 7 years ago

Pull Request #72

A few questions on meaning:

On line 9:

On line 19, I just want to be sure I have made sense of the text. If you want me to make further changes let me know.

davevs commented 7 years ago

Jerkins should be Jenkins (a popular continuous integration tool).

pristine = without flaws. In other terms; 'first time right'

It refers to the build tool. The whole purpose of CI/CD is that your tools are able to modify stuff.

Ambg05 commented 7 years ago

Thanks. I've made the changes to Line 9, I'll leave the issue open til I know line 19 is good.

DinisCruz commented 7 years ago

"It should be modifying stuff" is actually a mistake, in that context it should say "it should NOT be modifying stuff."

@Ambg05 don't worry about making that fix I will merge the PR and make a couple more changes

DinisCruz commented 7 years ago

ok just an updated version of chapter.

here is the diff of this new version https://github.com/DinisCruz/Book_SecDevOps_Risk_Workflow/commit/eab6490feac041523d172069b0fef23ad07db567#diff-6ab070f8156181d34ffb5d5075168bc2

@Ambg05 can you review this file too? (there are significant changes from the last version)

DinisCruz commented 7 years ago

closing since this file has been updated and fixed now