DinneK / the-hiding-place

1 stars 0 forks source link

Add tests and all classes #16

Closed DinneK closed 2 years ago

DinneK commented 2 years ago

This pull request should complete the all tests and classes functionality.

Next implementation of log in page:

questions:

notes:

DinneK commented 2 years ago

@hfaerber

INguyen22 commented 2 years ago

oooooh! great job using the find iterator. i didn't know you could use them that way since i always used find to only find one thing in the array!

-with how you set things up in your classes i believe you can just filter the rooms/bookings in your guest class since i saw you go through all the bookings data and changed them to have their room details according to their room number. -On the other hand, you could do separate kinds of filters in the room or booking class depending on what you're looking for and how you plan to go about your javascript. For example, a filter by room type in the rooms.js and a filter by date in the bookings.js. -if you plan to use the bookings data that was changed in your guest class to have more details, i think it would be easier to just filter in your guest class.

your tests look awesome, and remember to take it easy every now and then!