Change "type(x) is y" to "isinstance(x, y)"

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server

http://dinnerbone.com/minecraft/tools/status/

1.11k stars 146 forks source link

Change "type(x) is y" to "isinstance(x, y)" #108

Closed James-E-A closed 3 years ago

James-E-A commented 3 years ago

Per PEP 8, if you wanted to apply this.

The big case in which I can think of that this'd be an issue is if mcstatus were to be integrated as a dependency of some larger project that had its own subclassed types, it might avoid some breakage in that case.

kevinkjt2000 commented 3 years ago

Thanks for the contribution! After #104, I'll do another release.