search

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

Read requirements from file in setup.py #110

Closed Fyssion closed 3 years ago

Fyssion commented 3 years ago

Hi,

I noticed the requirements in requirements.txt and the install_requires in setup.py don't match. This was causing some requirement issues when installing the lastest versions (5.0.0/5.1.0) from PyPI since asyncio-dgram is missing from the setup.py install_requires.

To fix this, I've changed setup.py to read from the requirements files.

kevinkjt2000 commented 3 years ago

Thanks for doing this! Unfortunately, pinning to exact versions in setup.py is generally discouraged. That TODO should have mentioned pinning to version ranges instead. Would you mind updating the requirements.txt file to have >= symbols instead of ==? I can merge after that.

Fyssion commented 3 years ago

Alright, I think I've done that 👍