Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

Consider switching to dnspython instead of dnspython3 #132

Closed MartinHjelmare closed 3 years ago

MartinHjelmare commented 3 years ago

Background

Problem

Solution?

Thanks for your support of Home Assistant!

Iapetus-11 commented 3 years ago

I considered making this issue as Poetry also has a strict dependency resolver, and conflicts with the dnspython3 dependency this library requires was causing issues for me. I'd also appreciate it if it was switched!

In addition, the newer versions of dnspython support async resolving. The current lookup() method of MinecraftServer is not async, so it would be benificial for some people to have an async_lookup() method using the newer capabilities of dnspython.