Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

Fix issues preventing running tests with tox #184

Closed ItsDrike closed 2 years ago

ItsDrike commented 2 years ago

This PR fixes 2 issues which currently prevent running tests with tox:

  1. Currently, running tox (with activated poetry venv) was causing multiple issues since these versions didn't install the poetry dependencies, tox-poetry is a tool which adds this call while the tox environments are being made.
  2. The test_timeout.py test file used a patch which didn't actually work and caused the test to fail.

This should probably have somewhat higher priority and should be merged as soon as possible since without it tox isn't currently working.

kevinkjt2000 commented 2 years ago

Tox and tox-poetry are dev dependencies and the broken test is fixed now f6b7a09