search

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

Complex Description Styles are lacking test coverage #195

Closed kevinkjt2000 closed 2 years ago

kevinkjt2000 commented 2 years ago

We could be missing logic for inserting §r into the parsed descriptions, hard to say without good tests.

kevinkjt2000 commented 2 years ago

Putting this here so I can find it again later https://minecraft.fandom.com/wiki/Raw_JSON_text_format

kevinkjt2000 commented 2 years ago

That's okay, we're all volunteers here that contribute whenever we feel up to it. I went ahead with merging because the tests were passing and the PR was large enough already that I didn't want others to miss out on all the improvements by not branching from this. I did hold back from making an official release until we can switch the type checker.

On Fri, Jan 28, 2022 at 10:22 PM ItsDrike @.***> wrote:

I was working on that though the PR already got merged so I'll open a new one eventually with some more fixes that should've still been a part of cleanup, though I'm a bit busy now so it may not be that soon.

— Reply to this email directly, view it on GitHub https://github.com/Dinnerbone/mcstatus/issues/195#issuecomment-1024830036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7IU4X3TROZ7TCJPW63Q53UYNTPZANCNFSM5NCFGYMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

kevinkjt2000 commented 2 years ago

Gonna close this in favor of #204, where tests will certainly be added.