search

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

UDPAsyncSocketConnection cannot write anything special itself #214

Closed CoolCat467 closed 2 years ago

CoolCat467 commented 2 years ago

UDPAsyncSocketConnection's definition of write is an asynchronous function, while it's base class AsyncReadConnection's base class Connection expects write to be a synchronous function for all of the special write functions like write_utf. This appears to have never been detected because everything that uses UDPAsyncSocketConnection manually writes everything.

kevinkjt2000 commented 2 years ago

Duplicate of #210?

CoolCat467 commented 2 years ago

Kind of but not really. It's the same type of problem I guess you could say. Number 210's seems to be mostly focused on AsyncServerQuerier. This issue is about UDPAsyncSocketConnection. But both issues are about base classes thinking a function the subclass implements being a different type than they are, like synchronous instead of asynchronous.

ItsDrike commented 2 years ago

Hi @CoolCat467, the repo has been moved to py-mine/mcstatus (as can be seen from the README), please comment there, the issues have been migrated too so you can just find the corresponding one.