search

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

stop caring if the socket fails to close #56

Closed kevinkjt2000 closed 5 years ago

kevinkjt2000 commented 7 years ago

contains suggested fix for issue #53

kevinkjt2000 commented 7 years ago

@Dinnerbone could you review please?

MarkL4YG commented 7 years ago

it's good that you bring this up again but merging #51 would include your changes as @Klemek ran into these issues too

kevinkjt2000 commented 7 years ago

Hmmm, it seems #51 also gets the UDP Sockets. I missed that. I will add it to mine too, in the case that a new feature is not wanted as an addition to a bugfix.

MarkL4YG commented 7 years ago

Now @Dinnerbone would only need to answer ^^

kevinkjt2000 commented 7 years ago

@Dinnerbone?

kevinkjt2000 commented 6 years ago

Maybe if we are good this year, Santa will give us the gift of accepting PRs

MarkL4YG commented 6 years ago

Or a collaborator :see_no_evil:

kevinkjt2000 commented 6 years ago

If I had a twitter account, I would shoot dinnerbone a public tweet.

MarkL4YG commented 6 years ago

Well I just did that: https://twitter.com/MarkL4YG/status/929362396317175808 :P

kevinkjt2000 commented 6 years ago

Oooooooh @Dinnerbone Wherrrrrreee are youuuuuuuuuuuuuuuuu?

kevinkjt2000 commented 6 years ago

@Dinnerbone All I want for Christmaaaasssssssss is youuuuuuuuuuuuuuuuuuuuu. https://youtu.be/yXQViqx6GMY?t=38s

MarkL4YG commented 6 years ago

:smile: I guess I'll just fork this at some point ¯\_(ツ)_/¯

kevinkjt2000 commented 6 years ago

image

ghost commented 6 years ago

Lol

kevinkjt2000 commented 5 years ago

I'm still waiting to hear back from the pypi admins, but so far it seems like the suggested course of action would be to come up with a new name to publish to pypi with. https://github.com/pypa/warehouse/issues/3910 Honestly, since I've been waiting a year and a half or so, I'm tempted to just give up.

MarkL4YG commented 5 years ago

Don't be. I'm with you. A traditional fork on GitHub and a takeover on pypi seems to be reasonable to me. The original author is still clearly visible but project maintenance and updates can continue.

kevinkjt2000 commented 5 years ago

I will publish a new version when I get home tonight. I'm excited!

MarkL4YG commented 5 years ago

@kevinkjt2000 I am too 😉