search

Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server
http://dinnerbone.com/minecraft/tools/status/
1.11k stars 146 forks source link

Variable name change #89

Closed TheWlr9 closed 4 years ago

TheWlr9 commented 4 years ago

Changed the "retries" variable names in the actionable methods found in server.py to 'tries' which better represent what they are being treated as. (Ex previous: when setting retries=0, the method would not try once. However it should try at least once before attempting a retry)

kevinkjt2000 commented 4 years ago

If there were plans for another major version, I would have been more inclined to accept this into a branch. I don't foresee any other major changes though.

kevinkjt2000 commented 4 years ago

Hmmm what's stopping me from planning a major release? Perhaps nothing? Is one small rename worth it? image

I'll merge and bump the major version to release it.

kevinkjt2000 commented 4 years ago

4.0.0 is out https://pypi.org/project/mcstatus/4.0.0/