DinoDevs / GladiatusCrazyAddon

This was "A browser addon for the Gladiatus browser game."
https://gladiatus.dinodevs.com
GNU General Public License v3.0
41 stars 32 forks source link

Lvl, Armour & Damage not shown #353

Closed FilipSla closed 2 years ago

FilipSla commented 2 years ago

Improvement

I was tired of seeing this mess: image so I made few lines of code to improve it a little bit before they merge servers: const spanChange = document.querySelectorAll('.charstats_value21'); spanChange.forEach(charstats_value21 => { charstats_value21.style.marginRight = '10px'; }); After adding it to page it looks as nice as before 😅 image

FrutyX commented 2 years ago

Okay but... it's a bug, it's on Gameforge's known issues list, so what is the point of this? I guess only for personal use until they'll fix it, but there is no point to add this to GCA.

GramThanos commented 2 years ago

It's a feature.

FrutyX commented 2 years ago

Funny.

FilipSla commented 2 years ago

The only funny thing is that the developer didn't check how it would be displayed or it could be missclick. He put there margin 100px instead of 10px.

GramThanos commented 2 years ago

Gameforge always tests the codes, this is why it was deployed publicly, so that anyone can test.

FrutyX commented 2 years ago

Users are always the best testers, indeed.

FilipSla commented 2 years ago

And yes, it is mainly for personal usage.

GreatApo commented 2 years ago

I am assuming they will fix it so I propose not doing any actions until the servers merge. If it is still there, I will add the proposed code as a fix. @FilipSla , if it annoys you, you can add your code in the overview.js and player.js inject functions in your local copy.

FrutyX commented 2 years ago

How incompetent you must be, to not fix this day 1? Sure, it's not game breaking and the values can still be seen when you hover over the stats (+ in other places), and they are probably planning it to release the fix with the next version that is also planned, but still, one quick hotfix could fix it.

This is convincing me that Gladiatus could be only a huge mess after the merges.

GramThanos commented 2 years ago

I don't think they take the game seriously as it doesn't have a big player base. The servers merging could be a potential costs reduction. I am sure they patched it on day one but they wait for the scheduled update to release it.

When I reported a security issue to them a few months ago, they patched it in 2 days.

warkadiusz commented 2 years ago

Just in case someone checks that issue to find some solutions, here is temporary fix with custom uBlock filter:

gladiatus.gameforge.com##.charstats_value21:style(margin-right: 0 !important)
GreatApo commented 2 years ago

A fix for this has been added in the changelog for game version 4.6.1 which is going to be live tomorrow (probably on all servers).

FrutyX commented 2 years ago

Fixed by Gameforge, closing.